Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Dbt engine compat for fusion#20

Merged
fivetran-jamie merged 3 commits into
mainfrom
dbt-engine-compat
Jun 4, 2025
Merged

Dbt engine compat for fusion#20
fivetran-jamie merged 3 commits into
mainfrom
dbt-engine-compat

Conversation

@fivetran-jamie
Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:
v0.3.1

This PR addresses the following Issue/Feature(s):

dbt-labs/dbt-core#11493

Summary of changes:

Ensures compatibility with the new dbt engine being released on 5/28 at the dbt Launch Showcase by way of merging #19

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: dbt run && dbt test
    • Testing Instructions: Confirm the change addresses the issue(s) -- confirmed by dbt labs @b-per
    • Focus Areas: Nothing really

Changelog

  • Draft changelog for PR
  • Final changelog for release review

b-per and others added 2 commits May 29, 2025 17:17
Merging into working branch before releasing to main shortly
@fivetran-jamie fivetran-jamie self-assigned this May 29, 2025
id: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks') else 'varchar' }}"
plan_id: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks') else 'varchar' }}"
subscription_id: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks') else 'varchar' }}"
object: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks') else 'varchar' }}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch with all these btw

Copy link
Copy Markdown
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread CHANGELOG.md
## Documentation
- Corrected references to connectors and connections in the README. ([#18](https://github.com/fivetran/dbt_recurly_source/pull/18))

## Under the Hood
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go above documentation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

Comment thread CHANGELOG.md
@@ -1,8 +1,15 @@
# dbt_recurly_source version.version
# dbt_recurly_source v0.3.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This release introduces the following updates:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added myself directly

Copy link
Copy Markdown
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie two suggestions but ready to go after that.

@fivetran-jamie fivetran-jamie merged commit 4bdbcb8 into main Jun 4, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants