[fix] fix import error cased by _load_cuda_libs when running pytest#39
Open
Darryl233 wants to merge 2 commits intoflagos-ai:mainfrom
Open
[fix] fix import error cased by _load_cuda_libs when running pytest#39Darryl233 wants to merge 2 commits intoflagos-ai:mainfrom
Darryl233 wants to merge 2 commits intoflagos-ai:mainfrom
Conversation
|
liyuzhuo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
lxd-cumt
reviewed
Feb 26, 2026
|
|
||
| te_path = Path(importlib.util.find_spec("transformer_engine").origin).parent.parent | ||
| te_path_override = os.environ.get("TE_LIB_PATH") | ||
| if te_path_override: |
Collaborator
There was a problem hiding this comment.
In this PR, only the te_path in vendor/cuda was updated.
Don't the te_path entries under vendor/ for other hardware vendors (such as hygon) also need to be updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using pytest to test CI, the working directory is the TransformerEngine-FL project directory, and te_path points to the local source tree TransformerEngine-FL/. There are no .so files in the source tree (they are in build/ or site-packages), which causes it to return False.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: