fix: Loading page should always be possible to add to route #3800
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdabba-WORK
changed the title
gdabba-WORK
changed the title
gdabba-WORK
changed the title
gdabba-WORK
changed the title
gdabba-WORK
changed the title
spydon
reviewed
Jan 23, 2026
Member
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Can you explain what difference this makes?
Contributor
Author
|
The first time _addLoadingPage() is called, _loadingBuilder().addToParent() is called normally. However, if _addLoadingPage() is called more than once, _loadingPage.addToParent() is not called. Therefore, if a named route with maintainState set to false and a page with a long loading time is repeatedly pushed, the loading page will not be displayed as intended. Thanks! |
Member
|
@gdabba-WORK aaah, that makes sense. |
spydon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed so that when a named Route is repeatedly pushed, loadingPage can be added to that route.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues