Skip to content

BUG: Failing tests and outdated api version #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmmizerany wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BUG: Failing tests and outdated api version #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f7abf
bump api version, adjust paths
jmmizerany Apr 1, 2026
409bef3
remove version check for pagination
jmmizerany Apr 1, 2026
2a0332f
update schema for submitted_inspection_forms
jmmizerany Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap_fleetio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def get_url_params(
A dictionary of URL query parameters.
"""
params: dict = {}
if next_page_token and self.api_version == "2024-03-15":
Copy link
Copy Markdown
Collaborator Author

@jmmizerany jmmizerany Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't had any traffic, so this is a perfect time to simplify this line

if next_page_token:
params["start_cursor"] = next_page_token
params["per_page"] = 100
return params
Expand Down
8 changes: 4 additions & 4 deletions tap_fleetio/schemas/submitted_inspection_forms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@
"starting_latitude": {
"type": [
"null",
"number"
"string"
]
},
"starting_longitude": {
"type": [
"null",
"number"
"string"
]
},
"submitted_at": {
Expand All @@ -49,13 +49,13 @@
"submitted_latitude": {
"type": [
"null",
"number"
"string"
]
},
"submitted_longitude": {
"type": [
"null",
"number"
"string"
]
},
"user": {
Expand Down
40 changes: 20 additions & 20 deletions tap_fleetio/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,98 +12,98 @@
class IssuesStream(fleetioStream):

name = "issues"
path = "/v2/issues"
path = "/issues"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "issues.json" # noqa: ERA001


class ServiceEntriesStream(fleetioStream):

name = "service_entries"
path = "/v2/service_entries"
path = "/service_entries"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "service_entries.json" # noqa: ERA001


class SubmittedInspectionFormsStream(fleetioStream):

name = "submitted_inspection_forms"
path = "/v1/submitted_inspection_forms"
path = "/submitted_inspection_forms"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "submitted_inspection_forms.json" # noqa: ERA001


class VehiclesStream(fleetioStream):

name = "vehicles"
path = "/v1/vehicles"
path = "/vehicles"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "vehicles.json" # noqa: ERA001


class ExpenseEntriesStream(fleetioStream):

name = "expense_entries"
path = "/v1/expense_entries"
path = "/expense_entries"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "expense_entries.json" # noqa: ERA001


class ContactsStream(fleetioStream):

name = "contacts"
path = "/v2/contacts"
path = "/contacts"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "contacts.json" # noqa: ERA001


class FuelEntriesStream(fleetioStream):

name = "fuel_entries"
path = "/v1/fuel_entries"
path = "/fuel_entries"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "fuel_entries.json" # noqa: ERA001


class PartsStream(fleetioStream):

name = "parts"
path = "/v1/parts"
path = "/parts"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "parts.json" # noqa: ERA001


class PurchaseOrdersStream(fleetioStream):

name = "purchase_orders"
path = "/v1/purchase_orders"
path = "/purchase_orders"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "purchase_orders.json" # noqa: ERA001


class VehicleAssignmentsStream(fleetioStream):

name = "vehicle_assignments"
path = "/v1/vehicle_assignments"
path = "/vehicle_assignments"
primary_keys = ["id"]
api_version = "2024-03-15"
api_version = "2025-05-05"
records_jsonpath = "$.records[*]"
schema_filepath = SCHEMAS_DIR / "vehicle_assignments.json" # noqa: ERA001
Loading