You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this current state I don't think this PR should be merged as there's a little bit of style cleanup needed (some things don't need to be mut, etc.), docs, and tests should probably be added.
I wanted to get this PR submitted even in this state though to gauge interest in bringing this into project before making those changes. I saw in #5 that @mitsuhiko at least may have interest in this but it wasn't 100% clear to me.
In this current state I don't think this PR should be merged as there's a little bit of style cleanup needed (some things don't need to be mut, etc.), docs, and tests should probably be added.
I wanted to get this PR submitted even in this state though to gauge interest in bringing this into project before making those changes. I saw in #5 that @mitsuhiko at least may have interest in this but it wasn't 100% clear to me.
Sure, remove the WIP in title when you ready :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds serde support gated behind the
serdefeature flag, allowing public structures this library provides to be serialized.