docs: add secret references for static token authentication#399
docs: add secret references for static token authentication#399markphelps wants to merge 2 commits intomainfrom
Conversation
Update static token authentication docs to show how to use secret references to avoid hardcoding token values in configuration files. Includes examples for both file and HashiCorp Vault providers with cross-references to the secrets documentation. Also adds static token examples to the secrets.mdx usage section to demonstrate the feature alongside other authentication methods. Closes #349 Co-authored-by: Mark Phelps <markphelps@users.noreply.github.com>
ReviewOverall this is a well-structured addition that fills a clear gap in the docs. The cross-referencing between authentication, secrets, and the overview page is solid. A few notes below: Inconsistent quoting styleThe Both are valid YAML, but it's inconsistent within the same PR. The existing pattern in Missing inline comments in
|
- Add inline comments to authentication.mdx secret reference examples - Add second token to Vault example for symmetry with file example - Quote secret references in secrets.mdx for consistency - Add required: true to secrets.mdx provider examples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review (Corrected)A previous automated review was left on this PR with several inaccurate observations. This comment supersedes it with accurate findings. What is good
One minor issueIn secrets.mdx, the Vault provider token example is missing the inline comment that the file provider example has. The file provider includes a comment: credential followed by the secret reference followed by '# References /etc/flipt/secrets/ci-token' The Vault provider omits a similar annotation: credential followed by the vault secret reference with no comment. Adding a comment like '# References flipt/tokens secret, key: ci-token' would make it consistent with the file provider example and with the Vault examples in authentication.mdx. This is a solid addition overall—accurate, well-linked, and consistent with existing patterns. The minor comment omission is the only thing worth addressing before merging. |
Add documentation explaining how to use secret references to securely manage static authentication tokens in Flipt v2.
Changes
Closes #349
Generated with Claude Code