Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

feat: Minimal ONNX Node#299

Merged
roulbac merged 8 commits into
developfrom
feat/load-onnx-model
Sep 25, 2023
Merged

feat: Minimal ONNX Node#299
roulbac merged 8 commits into
developfrom
feat/load-onnx-model

Conversation

@jjerphan
Copy link
Copy Markdown
Contributor

@jjerphan jjerphan commented Sep 19, 2023

Description

  • I've included a concise description of what each node does

Styleguide

  • My node adheres to the styleguide for Flojoy nodes

Docs

  • I've submitted a PR for a documentation page for the new node(s) that contains usage examples (see docs.flojoy.io)

See: flojoy-ai/docs#396

Testing

  • This PR includes a unit test (example here and/or ideally a screenshot of the node's output on an example app).

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the feat/load-onnx-model branch from dfc31b8 to af222d2 Compare September 19, 2023 15:41
@jjerphan jjerphan force-pushed the feat/load-onnx-model branch from 33a27f2 to 8aa249d Compare September 20, 2023 09:13
For now, those tests sometimes fail on Windows it seem.

I wonder whether this is due to the setup of the
virtual environement via `run_in_venv` or not.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan marked this pull request as ready for review September 20, 2023 10:09
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jackparmer
Copy link
Copy Markdown
Contributor

@roulbac can u pls review this one and merge if all ok?

Copy link
Copy Markdown
Member

@itsjoeoui itsjoeoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for @roulbac to approve as well!

@itsjoeoui
Copy link
Copy Markdown
Member

Just missing an example then we are good :)

Copy link
Copy Markdown
Contributor

@roulbac roulbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jjerphan

@roulbac roulbac merged commit 9e8a69c into develop Sep 25, 2023
@jjerphan jjerphan deleted the feat/load-onnx-model branch September 26, 2023 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants