Fix auth VNC rendering with cloned Chrome profiles#2
Open
federicodeponte wants to merge 3 commits into
Open
Conversation
The auth portal (/auth/<token>) only supplied the VNC password to noVNC when trusted_client was true, so the owner opening the portal from an untrusted device (their phone) got a blank viewer. The portal token is itself the secret, so always auto-supply the password. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ock; fail loud if chrome window doesn't open Auth VNC sessions launched chrome on the shared identity profile which is SingletonLock'd by a live pool chrome, so the new chrome exited immediately and the display stayed black. Clone the profile (login state preserved) to a per-session temp dir, and raise if no visible window appears. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_errorso the portal shows launch failures.Verification
python3 -m compileall -q ax_browser_broker && python3 -m pytest -q-> 209 passed./root/.fleet-logs/auth-vnc-generic-example-hRynPErc.png, rendered Example Domain, non-black mean52110.5./root/.fleet-logs/auth-vnc-example-Pb5RDQvG.png, rendered Example Domain, non-black mean49072.8./root/.fleet-logs/auth-vnc-linkedin-logged-9ja6zMad.png, rendered LinkedIn feed, titleFeed | LinkedIn, no sign-in text./tmp/ax-auth-vnc-smoke-*and non-production VNC/websocket ports.Safe Reload Plan
/root/ax-browser-broker/bin/ax-browser-audit --jsonandcurl -s http://127.0.0.1:8767/status.python3 -m compileall -q ax_browser_broker && python3 -m pytest -q.systemctl restart ax-browser-broker.service. This leaves browser pool Chrome processes intact; no pool supervisor restart.https://example.com, captureDISPLAY=:<display> import -window root /root/.fleet-logs/auth-vnc-postreload.png, confirm non-black and titleExample Domain.