Account for Lorenza offset#2
Closed
KelseyCooper wants to merge 2 commits intois-visiblefrom
Closed
Conversation
KelseyCooper
force-pushed
the
lorenza-offset
branch
from
e627ff7 to
7798b17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Lorenza uses an offset on each slide that is within a wrapAround slider. This offset tricks Flickity into keeping slides overhanging the righthand side of the slider. This allows us to keep these slides from shifting to the start of the queue and moving to the left right after they have left the viewport.
The offset is by 1px for each slide, with a maximum of 4 slides.
This change allows us to offset the viewport width calculated within #1. We're offsetting by the maximum 4 pixels.
Edit
A problem with inline carousels has been found. Solution has been added and a note has been made on the original Flickity PR
Usage
"flickity": "https://github.com/fluorescent/flickity#e627ff7",