Merged
Conversation
- Updated fluree/json-ld dependency to git sha f82df2f9163924f0a5ff98e79e4a0bc338e3ddcd - New version produces standard expanded JSON-LD instead of proprietary format - Existing utility functions (get-first-value, get-value, etc.) already handle valid JSON-LD structure - Keyword usage as compact IRIs preserved with proper context support
Contributor
Author
|
@fluree/core this is ready for review |
dpetran
reviewed
Aug 14, 2025
src/fluree/db/connection/config.cljc
Outdated
| [node] | ||
| (if (subject-node? node) | ||
| (update node :id iri->kw) | ||
| (update node "@id" iri->kw) |
Contributor
There was a problem hiding this comment.
Can we use the const/iri-id and friends in this file instead of the string literal versions?
dpetran
reviewed
Aug 14, 2025
src/fluree/db/flake/flake_db.cljc
Outdated
| (and | ||
| (contains? mapx :set) | ||
| (= #{:set :idx} (set (keys mapx)))) | ||
| (contains? mapx "@set") |
Contributor
There was a problem hiding this comment.
Can we make a const for this?
dpetran
reviewed
Aug 14, 2025
src/fluree/db/flake/flake_db.cljc
Outdated
| [mapx] | ||
| (cond | ||
| (contains? mapx :value) | ||
| (contains? mapx "@value") |
Contributor
There was a problem hiding this comment.
And use a const for this as well.
dpetran
reviewed
Aug 14, 2025
src/fluree/db/query/fql/parse.cljc
Outdated
|
|
||
| (= :type pred) | ||
| (let [values* (map (fn [typ] {:id typ}) | ||
| (= "@type" pred) |
dpetran
reviewed
Aug 14, 2025
| :else jsonld)) | ||
| (if (contains? jsonld "@graph") | ||
| (get jsonld "@graph") | ||
| jsonld)) |
Contributor
There was a problem hiding this comment.
And consts in this file as well.
Contributor
Author
There was a problem hiding this comment.
We can't use a const here because of a circular dependency in the const namespace. At least, I'd rather not hold up this pr to resolve the circular dependency. I'll leave a TODO for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates our json-ld dependency to the version from fluree/json-ld#44 which changes the behavior of the json-ld library to return valid expanded json-ld data from the
fluree.json-ld/expandfunction, and makes all the necessary changes to use the new format for expanded json-ld data.