Fix unescaped JAVA_X variable in fluree_start.sh for Windows Bash compatibility (#217)#218
Fix unescaped JAVA_X variable in fluree_start.sh for Windows Bash compatibility (#217)#218Domenic-MZS wants to merge 1 commit intofluree:mainfrom
JAVA_X variable in fluree_start.sh for Windows Bash compatibility (#217)#218Conversation
- Escaped the JAVA_X variable to ensure proper handling in Windows WSL environments
JAVA_X in fluree_start.sh for windows bash compatibility (#217)
JAVA_X in fluree_start.sh for windows bash compatibility (#217)JAVA_X variable in fluree_start.sh for Windows Bash compatibility (#217)
|
Could I request a review from you as well on this Pull Request, @bplatz? Thank you in advance! 👾 |
|
Hi @Domenic-MZS Thanks for helping! Is there a reason the indenting was also modified? Unsure if there is a bash indentation convention you are also suggesting here, or if this is just your personal preference. |
Hi @bplatz! Thanks for reviewing the pull request 🔎🧾. The indenting changes were automatically applied by my Neovim's configured Language Server Protocol 👾, specifically the I aimed to align with the bash indentation convention for better readability and consistency within the codebase 📋. The intention was to maintain uniformity and follow established best practices ✅. If there's a different preferred standard or if these modifications don't align with the codebase guidelines, I'm more than willing to make the adjustments accordingly ✍🏼. |
Fix unescaped
JAVA_Xvariable influree_start.shfor Windows Bash compatibility (#217)This Pull Request (PR) introduces changes to the
fluree_start.shscript, specifically targeting theJAVA_Xvariable. The main aim is to ensure compatibility with Windows Subsystem for Linux (WSL) environments likeGIT BASH. This is achieved by properly escaping theJAVA_Xvariable. Closes issue #217.Overview
JAVA_Xvariable to work with Windows Path'slua_lsLSP file format🧪 Testing
resources/fluree_start.sh)📑 Notes
The Prerequisites list was incomplete, i had to check the
fluree/dbrepository and watch build errors to make it work, i choosed the build versionv2.0.4, and thezippackage is totally missing on any requirements list. It also required some base code (clojure) modifications related to the issue #213 to build. I will address that next if i get some free time.