Skip to content

release: 0.0.8 (dusk:install repoint to magic_devtools + doc/skill sync)#20

Merged
anilcancakir merged 3 commits into
masterfrom
fix/magic-devtools-install-repoint
Jun 17, 2026
Merged

release: 0.0.8 (dusk:install repoint to magic_devtools + doc/skill sync)#20
anilcancakir merged 3 commits into
masterfrom
fix/magic-devtools-install-repoint

Conversation

@anilcancakir

Copy link
Copy Markdown
Contributor

What

dusk:install injected import 'package:magic/dusk_integration.dart'; into a consumer's main.dart. That sub-barrel was removed from magic core (the Magic dusk adapter moved to the new magic_devtools package). After the move that import no longer resolves, so a fresh install produced a non-compiling main.dart.

  • Repoints the injected import to package:magic_devtools/dusk.dart.
  • Renames the gate _hasMagicDep -> _hasMagicDevtoolsDep (regex \n magic_devtools:) so the magic-side wiring is injected ONLY when the consumer has magic_devtools (dep or dev_dep), eliminating the unresolvable-import failure mode.
  • Updates docblocks, the install-command test, and CHANGELOG [Unreleased].

Verification

  • dart analyze 0 issues, dart format clean, 786 tests green, grep package:magic/dusk_integration lib test empty.

Targets release/0.0.7 so the fix ships with 0.0.7 (the version magic_devtools depends on). Generated via /ac:execute (plan: magic-stabilize-dusk-telescope).

Copilot AI review requested due to automatic review settings June 16, 2026 23:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes dusk:install for Magic-stack consumers after MagicDuskIntegration moved out of magic core into the new magic_devtools package, ensuring the injected main.dart remains compilable on fresh installs.

Changes:

  • Update dusk:install to inject import 'package:magic_devtools/dusk.dart'; and gate Magic integration wiring on magic_devtools in pubspec.yaml.
  • Update dusk_install_command_test.dart expectations/fixtures for the new import path and dependency gate.
  • Add a [Unreleased] changelog entry documenting the behavior change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
lib/src/commands/dusk_install_command.dart Repoints injected Magic integration import to magic_devtools and renames the dependency gate helper accordingly.
test/src/commands/dusk_install_command_test.dart Updates the Magic-stack install test to include magic_devtools and assert the new injected import.
CHANGELOG.md Documents the dusk:install injection/gating change under [Unreleased].

Comment thread lib/src/commands/dusk_install_command.dart Outdated
Comment thread lib/src/commands/dusk_install_command.dart Outdated
anilcancakir added a commit that referenced this pull request Jun 17, 2026
@anilcancakir

Copy link
Copy Markdown
Contributor Author

Both Copilot review notes addressed in cf5c8c3: gate the magic_devtools import on a real Magic.init anchor (hasMagicInit && _hasMagicDevtoolsDep()) so a magic_devtools-but-no-Magic.init app no longer gets an unused import that breaks consumer dart analyze; fix the dev_dependencies docblock wording; add a negative-case regression test (787 tests green, analyze/format clean).

…ls dep

dusk:install injected the now-removed package:magic/dusk_integration.dart
import (the adapter moved to the magic_devtools package). Repoint the
injected import to package:magic_devtools/dusk.dart and gate the magic-side
wiring on a magic_devtools dependency (_hasMagicDevtoolsDep) so a magic-only
consumer never gets an unresolvable import.
@anilcancakir anilcancakir force-pushed the fix/magic-devtools-install-repoint branch from cf5c8c3 to bfe5454 Compare June 17, 2026 12:23
@anilcancakir anilcancakir changed the title fix(install): repoint dusk:install to magic_devtools dusk barrel release: 0.0.8 (dusk:install repoint to magic_devtools + doc/skill sync) Jun 17, 2026
@anilcancakir anilcancakir changed the base branch from release/0.0.7 to master June 17, 2026 12:23
@anilcancakir

Copy link
Copy Markdown
Contributor Author

Updated to a proper 0.0.8 release PR (was incorrectly based on the stale release/0.0.7 branch; 0.0.7 is already published/frozen). Now: rebased onto master, base changed to master, pubspec 0.0.7 -> 0.0.8, CHANGELOG [Unreleased] -> [0.0.8].

The two Copilot review notes are addressed (commit ec7dc31, now in this PR):

  1. The magic_devtools import is gated on hasMagicInit && _hasMagicDevtoolsDep() so a magic_devtools-but-no-Magic.init app no longer gets an unused import that breaks dart analyze (+ a negative-case regression test).
  2. The docblock now references dev_dependencies (plural) correctly.

Also brought docs/skill/example fully up to date with the magic_devtools extraction + 0.0.8 (install snippet pins ^0.0.2 -> ^0.0.8, SKILL stamp -> 0.0.8, cli-commands gate magic -> magic_devtools, magic-integration.md import + dev_dependency, ARCHITECTURE attribution). dart analyze 0, dart format clean, 787 tests green.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Comment thread example/pubspec.yaml Outdated
Comment thread lib/src/commands/dusk_install_command.dart Outdated
Comment thread lib/src/commands/dusk_install_command.dart Outdated
Comment thread skills/fluttersdk-dusk/SKILL.md
Comment thread CHANGELOG.md
Comment thread test/src/commands/dusk_install_command_test.dart
- pubspec 0.0.7 -> 0.0.8 (0.0.7 is published; this ships the dusk:install
  repoint to package:magic_devtools/dusk.dart + the hasMagicInit gate).
- example/pubspec path-dep pin -> 0.0.8.
- CHANGELOG: promote [Unreleased] (install repoint + hasMagicInit fix) to
  [0.0.8] - 2026-06-17 + Documentation entry.
- doc/skill sync to the magic_devtools extraction: installation.md pin
  ^0.0.2 -> ^0.0.8, SKILL.md version+stamp -> 0.0.8, cli-commands.md gate
  magic -> magic_devtools, magic-integration.md import + dev_dependency
  note, ARCHITECTURE.md magic_devtools attribution.
@anilcancakir anilcancakir force-pushed the fix/magic-devtools-install-repoint branch from bfe5454 to 3d8fd3a Compare June 17, 2026 12:42
@anilcancakir

Copy link
Copy Markdown
Contributor Author

Addressed all 6 round-2 review notes (commit 3d8fd3a):

  1. example/pubspec.yaml — dropped the redundant version: key from the fluttersdk_dusk path dep (kept path: ..); flutter pub get clean.
  2. dusk_install_command.dart:19 — docblock now says "a pubspec dependency or dev_dependency" (matches _hasMagicDevtoolsDep()).
  3. dusk_install_command.dart:236 — Step-3 comment "pulls in magic" → "pulls in magic_devtools".
  4. Tool counts — SKILL.md (desc + Tool-surface heading) and the pubspec comment corrected to 34 CLI / 33 MCP (30 ext.dusk. + 3 artisan:dusk.*)*, matching README/CLAUDE/pubspec-description.
  5. Missed docsdoc/commands/dusk-install.md (gate magic:magic_devtools: at the anchor-modes + step list + the pubspec-inspection table row, plus the injected package:magic_devtools/dusk.dart import) and doc/getting-started/installation.md (integration table Package column magicmagic_devtools, snippet import) are now in sync.
  6. test reason — wrapped await Magic.init( in backticks.

dart analyze 0, dart format clean, 787 tests green.

@anilcancakir anilcancakir merged commit 3c6ac99 into master Jun 17, 2026
2 checks passed
@anilcancakir anilcancakir deleted the fix/magic-devtools-install-repoint branch June 17, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants