release: 0.0.8 (dusk:install repoint to magic_devtools + doc/skill sync)#20
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes dusk:install for Magic-stack consumers after MagicDuskIntegration moved out of magic core into the new magic_devtools package, ensuring the injected main.dart remains compilable on fresh installs.
Changes:
- Update
dusk:installto injectimport 'package:magic_devtools/dusk.dart';and gate Magic integration wiring onmagic_devtoolsinpubspec.yaml. - Update
dusk_install_command_test.dartexpectations/fixtures for the new import path and dependency gate. - Add a
[Unreleased]changelog entry documenting the behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/src/commands/dusk_install_command.dart | Repoints injected Magic integration import to magic_devtools and renames the dependency gate helper accordingly. |
| test/src/commands/dusk_install_command_test.dart | Updates the Magic-stack install test to include magic_devtools and assert the new injected import. |
| CHANGELOG.md | Documents the dusk:install injection/gating change under [Unreleased]. |
…r present (PR #20 review)
|
Both Copilot review notes addressed in cf5c8c3: gate the magic_devtools import on a real |
…ls dep dusk:install injected the now-removed package:magic/dusk_integration.dart import (the adapter moved to the magic_devtools package). Repoint the injected import to package:magic_devtools/dusk.dart and gate the magic-side wiring on a magic_devtools dependency (_hasMagicDevtoolsDep) so a magic-only consumer never gets an unresolvable import.
…r present (PR #20 review)
cf5c8c3 to
bfe5454
Compare
|
Updated to a proper 0.0.8 release PR (was incorrectly based on the stale The two Copilot review notes are addressed (commit
Also brought docs/skill/example fully up to date with the magic_devtools extraction + 0.0.8 (install snippet pins ^0.0.2 -> ^0.0.8, SKILL stamp -> 0.0.8, cli-commands gate magic -> magic_devtools, magic-integration.md import + dev_dependency, ARCHITECTURE attribution). |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- pubspec 0.0.7 -> 0.0.8 (0.0.7 is published; this ships the dusk:install repoint to package:magic_devtools/dusk.dart + the hasMagicInit gate). - example/pubspec path-dep pin -> 0.0.8. - CHANGELOG: promote [Unreleased] (install repoint + hasMagicInit fix) to [0.0.8] - 2026-06-17 + Documentation entry. - doc/skill sync to the magic_devtools extraction: installation.md pin ^0.0.2 -> ^0.0.8, SKILL.md version+stamp -> 0.0.8, cli-commands.md gate magic -> magic_devtools, magic-integration.md import + dev_dependency note, ARCHITECTURE.md magic_devtools attribution.
bfe5454 to
3d8fd3a
Compare
|
Addressed all 6 round-2 review notes (commit 3d8fd3a):
|
What
dusk:installinjectedimport 'package:magic/dusk_integration.dart';into a consumer's main.dart. That sub-barrel was removed from magic core (the Magic dusk adapter moved to the newmagic_devtoolspackage). After the move that import no longer resolves, so a fresh install produced a non-compilingmain.dart.package:magic_devtools/dusk.dart._hasMagicDep->_hasMagicDevtoolsDep(regex\n magic_devtools:) so the magic-side wiring is injected ONLY when the consumer hasmagic_devtools(dep or dev_dep), eliminating the unresolvable-import failure mode.[Unreleased].Verification
dart analyze0 issues,dart formatclean, 786 tests green,grep package:magic/dusk_integration lib testempty.Targets
release/0.0.7so the fix ships with 0.0.7 (the version magic_devtools depends on). Generated via /ac:execute (plan: magic-stabilize-dusk-telescope).