fix: resolve sidebar overflow when browser height is insufficient#33
Merged
anilcancakir merged 2 commits intomainfrom Apr 8, 2026
Merged
fix: resolve sidebar overflow when browser height is insufficient#33anilcancakir merged 2 commits intomainfrom
anilcancakir merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Fixes the desktop sidebar overflow in MagicStarterAppLayout by making the navigation list independently scrollable when the viewport height is too small, aligning behavior with issue #29.
Changes:
- Wraps the sidebar/drawer navigation content in a
SingleChildScrollViewso nav items can scroll within the available height. - Adds a widget test intended to assert the presence of scrollability in the desktop sidebar navigation area.
- Documents the fix in
CHANGELOG.mdunder[Unreleased].
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/src/ui/layouts/magic_starter_app_layout.dart | Makes the navigation section scrollable by wrapping navigation content in SingleChildScrollView. |
| test/ui/layouts/magic_starter_app_layout_test.dart | Adds a regression test intended to verify sidebar navigation uses a scroll view. |
| CHANGELOG.md | Adds an Unreleased bug-fix entry describing the sidebar overflow fix. |
anilcancakir
force-pushed
the
fix/sidebar-overflow
branch
from
46e482e to
35eec25
Compare
anilcancakir
force-pushed
the
fix/sidebar-overflow
branch
from
831fcc4 to
5601087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SingleChildScrollViewso nav items scroll when they exceed available viewport heightCloses #29
Test plan
navigation area is scrollable via SingleChildScrollView— verifies scroll widget present in desktop layout