Conversation
Signed-off-by: Kevin Su <pingsutw@gmail.com>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5034 +/- ##
=======================================
Coverage 60.99% 60.99%
=======================================
Files 793 793
Lines 51350 51350
=======================================
Hits 31319 31319
Misses 17145 17145
Partials 2886 2886
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm 99% sure we don't use this workflow anywhere. Can you double-check and if that's the case, should we remove it? |
|
@eapolinario I revive end2end test. It only runs when merging PRs since it takes 15 minutes. https://github.com/flyteorg/flyte/actions/runs/8967710966/job/24626449666?pr=5034 |
Signed-off-by: Kevin Su <pingsutw@apache.org>
| @click.option( | ||
| "--parallel", | ||
| is_flag=True, | ||
| default=False, |
There was a problem hiding this comment.
Run flytesnacks workflow serially by default in the CI due to disk pressure in the sandbox.
eapolinario
left a comment
eapolinario
left a comment
There was a problem hiding this comment.
That's pretty cool. Thank you!
Signed-off-by: Kevin Su <pingsutw@apache.org>
|
Just found that we already have end2end tests here, so we don't need |
pingsutw
changed the title
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Vladyslav Libov <vladyslav.libov@d-fine.de>
3 participants
Tracking issue
NA
What changes were proposed in this pull request?
We already have end2end tests here, so we don't need end2end.yml anymore
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytectl#462
Docs link