Initial executor <> Plugins integration#6903
Draft
EngHabu wants to merge 10 commits intoenghabu/state-etcdfrom
Draft
Initial executor <> Plugins integration#6903EngHabu wants to merge 10 commits intoenghabu/state-etcdfrom
EngHabu wants to merge 10 commits intoenghabu/state-etcdfrom
Conversation
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
This was referenced Feb 8, 2026
Open
Draft
Draft
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
machichima
reviewed
Feb 23, 2026
Comment on lines
+117
to
+119
| // Resolve plugin from registry | ||
| p, err := r.PluginRegistry.ResolvePlugin(taskAction.Spec.TaskType) | ||
| if err != nil { |
Member
There was a problem hiding this comment.
I'm thinking of moving this to a validation function, as well as validating other fields in taskAction, and put this validation function before we add the finalizer. In this case, if the validation failed, we can just not requeue it, and do not need to remove the finalizer.
We can do this in follow-up!
machichima
reviewed
Feb 24, 2026
Comment on lines
+252
to
+253
| setCondition(ta, flyteorgv1.ConditionTypeProgressing, metav1.ConditionTrue, | ||
| flyteorgv1.ConditionReasonExecuting, info.Reason()) |
Member
There was a problem hiding this comment.
For future PR: we should probably add max retry and fail this if exceed
machichima
reviewed
Feb 24, 2026
machichima
reviewed
Feb 24, 2026
popojk
reviewed
Feb 24, 2026
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
rely fully on task action conditions Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
machichima
reviewed
Feb 24, 2026
Member
There was a problem hiding this comment.
It was included in the.gitignore, I think some PR accidentally adding it back
Line 44 in b142044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh haytham@afutuh.com
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main