fix: use correct workflow name/version in execution breadcrumbs#897
Open
blaketastic2 wants to merge 1 commit intoflyteorg:masterfrom
Open
fix: use correct workflow name/version in execution breadcrumbs#897blaketastic2 wants to merge 1 commit intoflyteorg:masterfrom
blaketastic2 wants to merge 1 commit intoflyteorg:masterfrom
Conversation
Previously, getTaskOrWorkflowName and getTaskOrWorkflowVersion always returned the launch plan name/version, even for workflow executions. Now they check the resource type and return workflowId fields for workflows, matching the existing isExecutionTaskOrWorkflow logic. Signed-off-by: Blake <blaketastic2@gmail.com>
blaketastic2
force-pushed
the
fix/breadcrumb-workflow-name
branch
from
cc5676f to
b8afffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes breadcrumbs showing launch plan name instead of workflow name for workflow executions.
Type
Are all requirements met?
Complete description
getTaskOrWorkflowNameandgetTaskOrWorkflowVersionin the breadcrumb execution context always returned the launch plan name/version, regardless of whether the execution was for a task or workflow. For workflow executions this is incorrect — the breadcrumb should display the workflow name fromclosure.workflowId.Now both functions check the resource type via
isExecutionTaskOrWorkflowand returnworkflowId.name/workflowId.versionfor workflows, falling back tospec.launchPlanfor tasks.Also exported the three helper functions and added unit tests covering both task and workflow execution paths.
Tracking Issue
Follow-up issue