Skip to content

Comments

Add S3 addressing style configuration support#3367

Merged
pingsutw merged 2 commits intoflyteorg:masterfrom
ranjit-parva:feature/addressing-style
Feb 24, 2026
Merged

Add S3 addressing style configuration support#3367
pingsutw merged 2 commits intoflyteorg:masterfrom
ranjit-parva:feature/addressing-style

Conversation

@ranjit-parva
Copy link
Contributor

@ranjit-parva ranjit-parva commented Jan 14, 2026

  • Add adressing_style field to S3Config
  • Add S3_ADDRESSING_STYLE config entry with support for legacy and YAML config
  • Configure S3 client to use virtual addressing style when specified

Related PR:
flyteorg/stow#20

- Add adressing_style field to S3Config
- Add S3_ADDRESSING_STYLE config entry with support for legacy and YAML config
- Configure S3 client to use virtual addressing style when specified
@welcome
Copy link

welcome bot commented Jan 14, 2026

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@kumare3
Copy link
Contributor

kumare3 commented Jan 14, 2026

Why do you need addressing style? The yaml config entry will break flytectl in struct mode as that config is not there

@davidmirror-ops
Copy link
Contributor

@ranjit-parva thanks for your contribution.
Could you elaborate on what problem this solves? I'm struggling a bit to understand why this is needed

@ranjit-parva
Copy link
Contributor Author

@ranjit-parva thanks for your contribution. Could you elaborate on what problem this solves? I'm struggling a bit to understand why this is needed

Virtual Host-style and Path-style addressing differ in how the bucket name is positioned within the URL, either as a subdomain or as part of the path. Virtual Host-style (e.g., https://bucket.s3.amazonaws.com) is the current AWS standard and is required for all buckets created after September 2020 to ensure better traffic routing and scalability. Path-style (e.g., https://s3.amazonaws.com/bucket) is considered legacy but remains widely used in local development environments like LocalStack or MinIO for easier DNS configuration.

By default path sytle is picked by boto. This config enables users to set virtual host style.

kumare3 pushed a commit to flyteorg/flyte-sdk that referenced this pull request Feb 24, 2026
…ends (#703)

## Summary

- Adds `addressing_style` field to the `S3` config class, readable via
the `FLYTE_AWS_S3_ADDRESSING_STYLE` env var
- When set to `virtual`, passes `virtual_hosted_style_request=True` to
obstore so URLs are constructed as `https://<bucket>.<endpoint>/<key>`
instead of `https://<endpoint>/<bucket>/<key>`
- Replicates
[flyteorg/flytekit#3367](flyteorg/flytekit#3367)
into flyte-sdk (v2)

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
@pingsutw pingsutw merged commit c0921e9 into flyteorg:master Feb 24, 2026
56 checks passed
@welcome
Copy link

welcome bot commented Feb 24, 2026

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants