Fix heap fragmentation causing periodic crashes#1
Open
fmck3516 wants to merge 2 commits into
Open
Conversation
Replace Arduino String objects in displayCall/formatTime with fixed char buffers to prevent heap fragmentation from 10 allocations/second. Also fix PIN_LAST_ACTIVE type (long long → unsigned long + bool flag) to eliminate signed/unsigned mixing in millis() arithmetic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace unsigned long PIN_LAST_ACTIVE with uint64_t, backed by a new uptimeMs() function that detects each 49.7-day millis() rollover and accumulates an epoch counter. This produces a monotonically increasing 64-bit timestamp that makes debounce arithmetic correct indefinitely without requiring periodic reboots. The previous unsigned long approach handled single rollovers correctly but produced a false-active window every ~49.7 days when elapsed time coincided with an exact multiple of the 32-bit period. uptimeMs() is called at least once per 100ms loop iteration, so rollover detection is guaranteed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Arduino String objects in displayCall/formatTime with fixed char buffers to prevent heap fragmentation from 10 allocations/second. Also fix PIN_LAST_ACTIVE type (long long → unsigned long + bool flag) to eliminate signed/unsigned mixing in millis() arithmetic.