Fix compile time format for ranges, style and std#4759
Merged
Conversation
j4niwzis
force-pushed
the
main
branch
3 times, most recently
from
915aad7 to
be3ae4e
Compare
vitaut
requested changes
Apr 30, 2026
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR. Overall looks good but please fix CI errors.
Contributor
Author
It should work now |
Contributor
|
Lint error is unrelated (please rebase) but there are still errors that do look related. |
Contributor
|
@j4niwzis do you plan to update this PR? |
Contributor
Author
|
There seem to be no errors now |
vitaut
reviewed
May 28, 2026
|
|
||
| template <typename Context> | ||
| auto format(const std::exception& ex, Context& ctx) const | ||
| FMT_CONSTEXPR auto format(const std::exception& ex, Context& ctx) const |
Contributor
There was a problem hiding this comment.
I don't think this will work because what() will only be constexpr in C++26.
Contributor
There was a problem hiding this comment.
Anyway, this is a minor thing that can be addressed separately.
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compile time format for ranges, style and std