Avoid leaking backend error details in HTTP responses#331
Merged
Conversation
The chunk and index HTTP handlers echoed raw error strings from the upstream store into response bodies (e.g., S3/SFTP/GCS error messages may contain bucket names, hostnames, paths, or signed URLs) and the upstream store identifier in the "not enabled" / "does not support writing" responses. Log the detail to stderr and return a generic message to the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chunk-server and index-server HTTP handlers echoed raw upstream-store errors and store identifiers into response bodies. On an Internet-exposed server that leaks backend detail to clients:
writing to upstream ... is not enabledandupstream ... does not support writingresponses.Changes
All error paths that previously emitted backend-derived text to the client now:
Client-input errors remain intact since they describe the caller's own request:
NewChunkFromStorage(PUT chunk)invalid index: ...fromIndexFromReader(PUT index)idFromPathStatus codes are preserved; only the response body is changed. The returned
errorfromvalidateWritablestill contains the store identifier for the server-side caller, but the HTTP response no longer does.Existing
chunk-server/index-servertests pass unchanged.