NEW @W-21101982@ Adding ignores object in config file#408
Merged
namrata111f merged 7 commits intodevfrom Feb 10, 2026
Merged
Conversation
| @@ -1,5 +1,6 @@ | |||
| import fs from "node:fs"; | |||
| import path from "node:path"; | |||
| import {Minimatch} from "minimatch"; | |||
Contributor
There was a problem hiding this comment.
Ignore patterns likely won’t match on Windows due to path separator mismatch. minimatch expects /-separated paths, but matchesIgnorePattern feeds it path.sep (backslashes on Windows). This will make ignores.files silently ineffective on Windows unless users write \-escaped patterns. Normalize to POSIX separators before matching (e.g., pathToMatch.replaceAll(path.sep, "/")).
were you able to test it for windows ?
Contributor
Author
There was a problem hiding this comment.
That's a good catch. But shouldn't windows user be giving the file path as '\' as well in the ignore section if that is how the paths comes up for them?
Contributor
Author
There was a problem hiding this comment.
Have added POSIX normalization for now.
aruntyagiTutu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new ignore object in config file which users can use to add file paths/glob patterns to skip running rules for all the engines.
Testing:
Case-1) Tested with the ignore patterns:
Violations reported skipped the files covered in these patterns.
Case-2) Tested with no ignores object in the config files. The output contained all the expected violations.