Skip to content

chore: remove unused code#166

Open
ascandone wants to merge 1 commit into
mainfrom
feat/revert-involved-accounts-ast-output
Open

chore: remove unused code#166
ascandone wants to merge 1 commit into
mainfrom
feat/revert-involved-accounts-ast-output

Conversation

@ascandone

Copy link
Copy Markdown
Contributor

No description provided.

@NumaryBot

Copy link
Copy Markdown
Contributor

✅ Approve — automated review

The diff only removes the involved-accounts implementation, tests, and exported wrapper, and no remaining repository references appear to depend on those symbols. I did not identify a concrete regression within the checked-out code.

No findings.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f0298f0-0c14-4b51-bf7d-5ad191e547b4

📥 Commits

Reviewing files that changed from the base of the PR and between 22135a6 and 7c2afa1.

📒 Files selected for processing (4)
  • accounts/accounts.go
  • internal/interpreter/get_involved_accounts.go
  • internal/interpreter/get_involved_accounts_test.go
  • numscript.go
💤 Files with no reviewable changes (4)
  • accounts/accounts.go
  • internal/interpreter/get_involved_accounts.go
  • internal/interpreter/get_involved_accounts_test.go
  • numscript.go

Walkthrough

numscript.go no longer imports accounts and no longer exposes ParseResult.GetInvolvedAccounts. The involved-accounts path is removed from the public API.

Changes

Removed involved-accounts API

Layer / File(s) Summary
Import and method removal
numscript.go
The accounts import is removed, and ParseResult.GetInvolvedAccounts is deleted from the exported API.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Azorlogh
  • gfyrag

Poem

🐇 I hopped through the script with a prune and a twitch,
the old account trail gave a final little hitch.
No imports to nibble, no method to track,
just a tidy burrow where the API went back.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the intent cannot be assessed beyond the code changes. Add a brief description of what was removed and why, so reviewers can confirm the change intent.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removal of unused code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/revert-involved-accounts-ast-output

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.06%. Comparing base (9ca635b) to head (7c2afa1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   68.52%   70.06%   +1.53%     
==========================================
  Files          56       55       -1     
  Lines        5417     5024     -393     
==========================================
- Hits         3712     3520     -192     
+ Misses       1494     1312     -182     
+ Partials      211      192      -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ascandone ascandone requested a review from gfyrag June 26, 2026 10:28
@ascandone ascandone enabled auto-merge (squash) June 26, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants