Fix React embed ESM packaging for Vite 8#192
Open
byrnehollander wants to merge 6 commits intoformsort:masterfrom
Open
Fix React embed ESM packaging for Vite 8#192byrnehollander wants to merge 6 commits intoformsort:masterfrom
byrnehollander wants to merge 6 commits intoformsort:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
@formsort/react-embedand its direct embed dependency chain while preserving CJS entrypoints.@formsort/react-embedaround hooks, stable event callbacks, cleanup, StrictMode behavior, and prop-driven reloads.Why
A Vite 8 upgrade exposed that React embed and its dependency chain were still CJS-oriented, which caused the embed to break in modern ESM builds. This PR fixes that packaging issue for other consumers while also modernizing the small React wrapper code that was already being touched.
Upgrade path
This should be a minor upgrade for documented usage: root imports continue to work for ESM and CJS, and React embed props are not renamed or removed. It is minor rather than patch because package output changed and
EmbedFlownow reloads when load props such asclientLabel,flowLabel,variantLabel,queryParams, orembedConfigchange. Deeplib/*imports are internal and are not guaranteed.Verification
corepack yarn build,corepack yarn test,corepack yarn lintrequireand ESMimportsmoke testsCloses #184