Implement pinned drop sugar#9
Open
P8L1 wants to merge 3 commits intofrank-king:feature/pin-dropfrom
Open
Conversation
4 tasks
Author
|
@frank-king have you had time to review this by any chance? |
Owner
|
I'm not the proper reviewer for this PR, could you please open a PR directly merging to the upstream rust-lang/rust repo? (Note, you can open a draft PR and mark it ready since rust-lang#144537 is merged) |
7b57f41 to
7c656d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
fn drop(&pin mut self)as sugar forDrop::pin_drop.The resolver recognizes the sugar only for the actual
#[lang = "drop"]trait, maps accepted impl items to effectivepin_dropresolution, and passes marked impl item IDs to lowering. Lowering then emits HIR with identpin_drop, so existing type checking, Drop validation, drop glue, and direct-call checks remain unchanged.Drop identity is handled without a hardcoded
core::ops::drop::Droppath check. Local#[lang = "drop"]traits are recorded from raw AST attributes, and external Drop identity is checked through external lang-item metadata viadefined_lang_items. This avoids calling the all-cratestcx.lang_items()query from resolver.This intentionally preserves the base pinned-drop behavior where
#[pin_v2]types must usepin_drop, while non-#[pin_v2]types may still implementpin_drop.