Skip to content

feat(curriculum): Add speaking practice audio files to a subfolder#384

Merged
DanielRosa74 merged 5 commits intofreeCodeCamp:mainfrom
DanielRosa74:main
Feb 17, 2026
Merged

feat(curriculum): Add speaking practice audio files to a subfolder#384
DanielRosa74 merged 5 commits intofreeCodeCamp:mainfrom
DanielRosa74:main

Conversation

@DanielRosa74
Copy link
Contributor

Checklist:

@DanielRosa74 DanielRosa74 requested a review from a team as a code owner February 13, 2026 13:48
@DanielRosa74 DanielRosa74 changed the title Add speaking practice audio files to a subfolder feat(curriculum): Add speaking practice audio files to a subfolder Feb 13, 2026
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the challenge ID in the filename? Not sure I love it, but I don't really have any better ideas.

How come those first two don't have the same naming convention? 67fe9b-SP1.mp3 and 67fe9b-SP2.mp3

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve so you can merge if you want @DanielRosa74.

@DanielRosa74
Copy link
Contributor Author

Yeah, about the naming, discussing this with Huyen, this was the least complicated choice we could think of. The two different ones are the demo ones we already had in the regular path. When Huyen's PR to main is merged and platform updates, then we can remove these files. This is just to avoid not having the necessary files in the meantime.

@DanielRosa74 DanielRosa74 merged commit c6b6822 into freeCodeCamp:main Feb 17, 2026
2 checks passed
@ojeytonwilliams
Copy link
Contributor

Regarding names and whatnot: I highly recommend just giving them unique ids. There's nothing to be gained by tying them to challenge ids since you can easily search for the challenge if you know the speaking id.

@moT01
Copy link
Member

moT01 commented Feb 17, 2026

but how do you know what audio file is for what challenge? If we were to just give these random ID's, we would have to listen to the audio to figure out what challenge it's for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments