Skip to content

Update Dockerfile and wsgi.py to simplify waitress-serve command #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fakebizprez merged 1 commit into from
Jan 3, 2026
Merged

Update Dockerfile and wsgi.py to simplify waitress-serve command #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ HEALTHCHECK --interval=30s --timeout=10s --start-period=10s --retries=3 \
CMD python -c "import requests; requests.get('http://localhost:8080/health', timeout=5)" || exit 1

# Use Waitress for production deployment
CMD ["waitress-serve", "--host=0.0.0.0", "--port=8080", "--threads=1", "--channel-timeout=120", "--call", "wsgi:app"]
CMD ["waitress-serve", "--host=0.0.0.0", "--port=8080", "--threads=1", "--channel-timeout=120", "wsgi:app"]

@coderabbitai coderabbitai Bot Jan 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check the full Dockerfile to understand the context
git ls-files | grep -i dockerfile

Repository: freightCognition/temp_monitor

Length of output: 83

🏁 Script executed:

# Read the Dockerfile
cat -n Dockerfile | head -100

Repository: freightCognition/temp_monitor

Length of output: 1660

🏁 Script executed:

# Check for requirements.txt and waitress version
cat requirements.txt | grep -i waitress

Repository: freightCognition/temp_monitor

Length of output: 88

🏁 Script executed:

# Check for docker-compose.yml
git ls-files | grep -i docker-compose

Repository: freightCognition/temp_monitor

Length of output: 91

🏁 Script executed:

# Check docker-compose.yml for ARM build, privileged, I2C, /sys configuration
cat docker-compose.yml

Repository: freightCognition/temp_monitor

Length of output: 934

🏁 Script executed:

# Check wsgi.py to verify app object structure
cat wsgi.py

Repository: freightCognition/temp_monitor

Length of output: 1047

Add ARM build support to docker-compose.yml.

The waitress-serve syntax on line 43 is correct—positional argument for direct app reference is appropriate since wsgi:app references the app object directly (not a factory function). However, the docker-compose.yml is missing required ARM build support. Per coding guidelines, Docker Compose deployments must include ARM build specification for the target Raspberry Pi 4 platform. Add build.platforms: ["linux/arm/v7", "linux/arm64/v8"] to the temp-monitor service in docker-compose.yml to ensure proper multi-architecture builds.

🤖 Prompt for AI Agents 
In Dockerfile around lines 43 to 43, the container run command is fine but the
docker-compose.yml is missing ARM build support for Raspberry Pi 4; open
docker-compose.yml and under the temp-monitor service add a build.platforms
entry with the two required platforms: ["linux/arm/v7","linux/arm64/v8"] so
docker-compose can perform multi-architecture builds for ARM and ARM64 targets.

4 changes: 2 additions & 2 deletions wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
for use with Waitress or other WSGI servers.

Usage:
waitress-serve --host=0.0.0.0 --port=8080 --threads=1 --call wsgi:app
waitress-serve --host=0.0.0.0 --port=8080 --threads=1 wsgi:app

Or in docker-compose.yml:
CMD ["waitress-serve", "--host=0.0.0.0", "--port=8080", "--threads=1", "--call", "wsgi:app"]
CMD ["waitress-serve", "--host=0.0.0.0", "--port=8080", "--threads=1", "wsgi:app"]
"""

import logging
Expand Down