Don't raise high-level exceptions in proto conversion function#246
Merged
Conversation
`UnrecognizedEnumValueError` should only be raised from high-level wrappers, not protobuf conversion functions. Replace it with a simple `ValueError`, in this case someone just called the function with the wrong arguments. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
florian-wagner-frequenz
and removed request for
a team
github-actions
Bot
added
part:tests
llucax
added
the
cmd:skip-release-notes
shsms
approved these changes
Jul 9, 2026
Merged
via the queue into
frequenz-floss:v0.x.x
with commit Jul 9, 2026
e385d08
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnrecognizedEnumValueErrorshould only be raised from high-level wrappers, not protobuf conversion functions. Replace it with a simpleValueError, in this case someone just called the function with the wrong arguments.