Feat/adding custom label and dimensions names#4
Feat/adding custom label and dimensions names#4Tabhi109 wants to merge 3 commits intofrolicflow:mainfrom
Conversation
|
We need it for all the charts which has X and Y Axis. |
|
Refer to recharts documentation https://recharts.org/en-US/api/YAxis#label |
|
Okay got it ! |
|
added names functionality in all the charts with x and y axis |
|
Can you explain why you have decided to use Tooltip for Axis labels? Axis labels can be defined inside the axis tags themselves: https://recharts.org/en-US/api/YAxis#label |
|
@arihantparsoya I added the names using the ToolTip component so that It will be more interactive for users as well as a Cleaner UI will be maintained when there will be a large set of data, but as you want this to be in Axis itself, I will work on it! |
|
Yes, the the axis is the main thing, user should be able to know the axis without using the tooltips. Can you share a screenshot of the tooltip after your modified code? I would suggest keep the tooltip changes in separate branch and focus only on the axis for not. because tooltip is defined in other locations as well. |
labelNamesanddimensionsNamesin the interfaceChartInterfaceTooltipfor viewing the custom Label & Dimension Names.storybook