Skip to content

Remove unnecessary clone in tally #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HellFelix merged 1 commit into from
Apr 12, 2026
Merged

Remove unnecessary clone in tally #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions rustsystem-server/src/vote_auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ impl VoteRound {
}

pub fn tally(self) -> Result<Tally, APIError> {
let votes = self.votes.clone();
Tally::compute(votes, &self.metadata.get_candidates())
Tally::compute(self.votes, &self.metadata.get_candidates())
}
}

Expand Down Expand Up @@ -158,7 +157,12 @@ impl VoteAuthority {
*self.state_tx.borrow() == VoteState::Creation
}

pub fn start_round(&mut self, metadata: BallotMetaData, header: String, public_key: BBSplusPublicKey) {
pub fn start_round(
&mut self,
metadata: BallotMetaData,
header: String,
public_key: BBSplusPublicKey,
) {
let header_bytes = header.as_bytes().to_vec();
let expired_signatures = HashSet::new();
if let Err(e) = self.state_tx.send(VoteState::Voting) {
Expand Down
Loading