Occlusion culling#10
Open
PixelDust22 wants to merge 19 commits into
Open
Conversation
bonsairobo
requested changes
Nov 30, 2022
Collaborator
bonsairobo
left a comment
bonsairobo
left a comment
There was a problem hiding this comment.
Looking good! Just needs a few changes.
| features = ["bevy_asset", "bevy_core_pipeline", "bevy_render", "x11"] | ||
|
|
||
| [patch."crates-io"] | ||
| bevy = { path = "../bevy" } |
Collaborator
There was a problem hiding this comment.
We should figure out what to do about this. If we need upstream bevy changes, let's make a PR and get this repo pointing to the branch.
bonsairobo
reviewed
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occlusion culling implementation. We take the z-buffer from last frame, generate a mipmap for it, and for each primitive we can test them against the HiZ buffer and discard them as needed.
Note that the
TEXTURE_BINDINGusage must be added to bevy when creating the depth texture. This is going to be a separate PR into bevy.