Skip to content

Conversation

@knocte
Copy link
Contributor

@knocte knocte commented Jan 7, 2026

This way it is an alternative to Seq.skip: same but
non-partial function (that doesn't throw exceptions),
following same approach as tryHeadTail[1].

[1] fdbeaf2

@knocte
Copy link
Contributor Author

knocte commented Jan 7, 2026

@gdziadkiewicz hey do you mind helping me upgrade paket (and paket deps) from v6 to v8? I'm not a paket expert, I just replaced net6.0 with net8.0 and upgraded paket version (see last commit), but seems that is not enough (see build failure).

@gdziadkiewicz
Copy link
Collaborator

Hi @knocte , no problem, I will take a look tomorrow morning :)

@gdziadkiewicz
Copy link
Collaborator

Hi @knocte , let's keep the update and the trySkip separate. I prepared the update in #224 .

@knocte
Copy link
Contributor Author

knocte commented Jan 9, 2026

Lovely thanks; sounds good, I'll rebase as soon as 224 lands.

@gdziadkiewicz
Copy link
Collaborator

@knocte I'm working on making the Fable tests work after my changes, sorry for the wait

@gdziadkiewicz
Copy link
Collaborator

@knocte merged the other PR

This way it is an alternative to Seq.skip: same but
non-partial function (that doesn't throw exceptions),
following same approach as tryHeadTail[1].

[1] fdbeaf2
This way the compiler will make sure that this recursive
function will not cause stackoverflows.
@knocte
Copy link
Contributor Author

knocte commented Jan 19, 2026

@gdziadkiewicz hey, thanks! Rebased.

Now, it seems CI is failing because, even though your PR upgraded general things to .NET8.x(&F#v8.x), FSharp.Core seems to be still locked to 4.x.

How can I upgrade FSharp.Core to v8.x? I assume that I gotta change manually the version in packet.dependencies file, but I guess I gotta run something else after that change, to make it propagate to packet.lock file?

Thanks.

(BTW the PR can already be reviewed in case you have feedback, and I will address it too next time I update the PR, cheers.)

@knocte
Copy link
Contributor Author

knocte commented Jan 19, 2026

How can I upgrade FSharp.Core to v8.x? I assume that I gotta change manually the version in packet.dependencies file, but I guess I gotta run something else after that change, to make it propagate to packet.lock file?

Mmm, changing manually both files seemed to work. If this is ok lmk and I'll squash latest commit to get this ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants