Skip to content

fix: override sdtools loadConfiguration to prevent null classList errors #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billrice wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: override sdtools loadConfiguration to prevent null classList errors #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5445c0
fix: override sdtools loadConfiguration to prevent null classList errors
Apr 28, 2026
e98ed9e
ci: trigger build
Apr 28, 2026
2cbf9a2
ci: replace deprecated create-release with softprops/action-gh-releas…
Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
runs-on: ubuntu-latest
needs:
- version
permissions:
contents: write
env:
TARGET_VERSION: ${{needs.version.outputs.versionOut}}
SEM_VERSION: ${{needs.version.outputs.versionSemVerOut}}
Expand All @@ -29,23 +31,12 @@ jobs:
- name: Set version in manifest
run: jq --arg ver "$TARGET_VERSION" '.Version = $ver' ./resources/manifest.json > temp.json && mv temp.json ./resources/manifest.json
- run: docker build -t temp .
- run: docker run -v $(pwd)/tmpdist:/tmpdist temp sh -c "cp /dist/com.ftt.apimonkey.sdPlugin.zip /tmpdist/com.ftt.apimonkey.sdPlugin.zip"
- run: mkdir -p tmpdist && docker run -v $(pwd)/tmpdist:/tmpdist temp sh -c "cp /dist/com.ftt.apimonkey.sdPlugin.zip /tmpdist/com.ftt.apimonkey.sdPlugin.zip"
- name: release
uses: actions/create-release@v1
id: create_release
uses: softprops/action-gh-release@v2
with:
name: ${{ env.TARGET_VERSION }}
tag_name: ${{ env.SEM_VERSION }}
draft: false
prerelease: false
release_name: ${{ env.TARGET_VERSION }}
tag_name: ${{ env.SEM_VERSION }}
env:
GITHUB_TOKEN: ${{ github.token }}
- name: upload windows artifact
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ github.token }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: tmpdist/com.ftt.apimonkey.sdPlugin.zip
asset_name: com.ftt.apimonkey.sdPlugin.zip
asset_content_type: application/octet-stream
files: tmpdist/com.ftt.apimonkey.sdPlugin.zip
4 changes: 4 additions & 0 deletions resources/pi/pi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
<title>Settings</title>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/gh/barraider/streamdeck-easypi@latest/src/sdpi.css">
<script src="https://cdn.jsdelivr.net/gh/barraider/streamdeck-easypi@latest/src/sdtools.common.js"></script>
<script>
// Vue.js 负责数据绑定，禁用 sdtools 的自动表单填充，避免找不到 DOM 元素时报错
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new inline comment is in Chinese while the rest of this property inspector (labels/buttons) and repo metadata (e.g., resources/manifest.json) are in English. To keep the codebase consistent and maintainable for all contributors, please translate this comment to English (or make it bilingual).

Suggested change
// Vue.js 负责数据绑定，禁用 sdtools 的自动表单填充，避免找不到 DOM 元素时报错
// Vue.js handles data binding; disable sdtools automatic form population to avoid errors when DOM elements are not found

Copilot uses AI. Check for mistakes.
function loadConfiguration() {}
</script>
Comment on lines +12 to +15
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The code comment is in Chinese, whereas the rest of the project (including the Go source code, manifest, and PR description) is in English. To maintain consistency and ensure the codebase is accessible to all contributors, it is recommended to use English for comments. Furthermore, the loadConfiguration function is typically called with a settings parameter by the sdtools library. Including this parameter in your override, even if unused, makes the code more robust and better documents the expected API.

    <script>
        // Vue.js handles data binding; override loadConfiguration to prevent DOM errors from sdtools
        function loadConfiguration(settings) {}
    </script>

<script src="https://unpkg.com/vue@3/dist/vue.global.js"></script>
</head>
<body>
Expand Down