add Vietnamese Telex and VNI combiners#1890
Closed
tenextractor wants to merge 2 commits intofuto-org:masterfrom
Closed
add Vietnamese Telex and VNI combiners#1890tenextractor wants to merge 2 commits intofuto-org:masterfrom
tenextractor wants to merge 2 commits intofuto-org:masterfrom
Conversation
Zvonimir-FUTO
added
Enhancement
Contributor
Author
|
There is a bug that only occurs while typing in the Firefox address/search bar and there are 0 or 1 initial consonants, where a diacritic/tone mark isn't applied, but it only applies to the first word typed. Example (Telex):
I will try to fix this and remove the draft status if it is fixed. |
|
Did you fix yet? |
Contributor
Author
|
I haven't fixed the issue yet, but seeing as it only occurs in the Firefox address bar and I have not worked on fixing it so far, I marked this pull request as ready instead of delaying further because of this bug. |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
telex_demo.mp4