Add movable and resizable pinned action button (e.g. dictation/mic)#1933
Open
PimpinPumpkin wants to merge 2 commits intofuto-org:masterfrom
Open
Add movable and resizable pinned action button (e.g. dictation/mic)#1933PimpinPumpkin wants to merge 2 commits intofuto-org:masterfrom
PimpinPumpkin wants to merge 2 commits intofuto-org:masterfrom
Conversation
Pinned action buttons (e.g. the dictation/mic button) can now be repositioned to the left side of the suggestion bar and resized to Small, Normal, or Large — useful for tablet and in-car use where the default right-side small button is hard to tap. Changes: - ActionBar.kt: add PinnedActionsOnLeft and PinnedActionsSize settings keys; pass size through to ActionItemSmall; conditionally render pinned items on left or right of suggestion strip - Actions.kt: expose both new settings in Settings → Actions UI - strings-uix.xml: add string resources for the new settings
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pinned action buttons (e.g. the mic/dictation button) are currently fixed to the right side of the suggestion bar at a single small size. This is hard to use on tablets and in-car vertical screens (e.g. Tesla-style displays).
This PR adds two new settings under Settings → Actions:
Changes
ActionBar.kt: addPinnedActionsOnLeft(boolean) andPinnedActionsSize(int 0/1/2)SettingsKeys;ActionItemSmallnow accepts asizeparameter that scales button width and icon;PinnedActionItemsreads the size from the datastore;ActionBarrow conditionally renders pinned items before or after the suggestion strip based on the position settingActions.kt: expose both new settings in the Settings → Actions quick options sectionstrings-uix.xml: add string resources for the new setting labels and size optionsMotivation
Primarily motivated by tablet and in-car use where the right-side small mic button is difficult to tap accurately. Putting it on the left and making it larger significantly improves usability in those contexts.