Fixed a few issues with "Resume at" feature#3217
Open
E-D-W-I-N wants to merge 5 commits intofuto-org:masterfrom
Open
Fixed a few issues with "Resume at" feature#3217E-D-W-I-N wants to merge 5 commits intofuto-org:masterfrom
E-D-W-I-N wants to merge 5 commits intofuto-org:masterfrom
Conversation
…yback, ignore loader and loaderGame
…imized) overrides
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found a few issues with the "Resume at" button and decided to fix them.
This PR splits each meaningful change into a separate commit.
Issues with "Resume at"
Flickering button
The "Resume at" button briefly appears before the game loads.
Video
1-out.mp4
Redundant visibility updates
updateResumeVisibilityForis called on every playback position change viasetLastPositionMilliseconds, even when the button is already hidden.This overrides the hide behavior when entering PiP mode, resulting in a non-interactable button in PiP.
Video
2-out.mp4
Incorrect behavior in minimized state (important stuff)
The "Resume at" button remains clickable when the player is minimized.
Instead of maximizing the player, it seeks to the last playback position.
Video
3-out.mp4
Final Result:
4-out.mp4
Additional changes