Skip to content

Fixed a few issues with "Resume at" feature#3217

Open
E-D-W-I-N wants to merge 5 commits intofuto-org:masterfrom
E-D-W-I-N:resume-fixes
Open

Fixed a few issues with "Resume at" feature#3217
E-D-W-I-N wants to merge 5 commits intofuto-org:masterfrom
E-D-W-I-N:resume-fixes

Conversation

@E-D-W-I-N
Copy link

Hi, I found a few issues with the "Resume at" button and decided to fix them.
This PR splits each meaningful change into a separate commit.

Issues with "Resume at"

  1. Flickering button
    The "Resume at" button briefly appears before the game loads.

    Video
    1-out.mp4
    → Fixed in a4f3d4f
  2. Redundant visibility updates
    updateResumeVisibilityFor is called on every playback position change via setLastPositionMilliseconds, even when the button is already hidden.
    This overrides the hide behavior when entering PiP mode, resulting in a non-interactable button in PiP.

    Video
    2-out.mp4
    → Fixed in 276c67d
  3. Incorrect behavior in minimized state (important stuff)
    The "Resume at" button remains clickable when the player is minimized.
    Instead of maximizing the player, it seeks to the last playback position.

    Video
    3-out.mp4
    → Fixed in b131fa9

Final Result:

4-out.mp4

Additional changes

  • Extracted "Resume at" into string resources
  • Added Russian translation

@futo-cla-pr-labler
Copy link

Please sign our contributor license agreement at https://cla.futo.org

@futo-cla-pr-labler
Copy link

Please sign our contributor license agreement at https://cla.futo.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant