-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
deps: remove iplib in favor of net/netip #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kotakanbe
wants to merge
5
commits into
master
Choose a base branch
from
diet-iplib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ac27614
deps: remove iplib
kotakanbe 1d879a8
Merge branch 'master' into diet-iplib
kotakanbe 04d3d5f
Merge branch 'master' into diet-iplib
kotakanbe 4f42493
Merge branch 'master' into diet-iplib
kotakanbe c35f046
fix: address Copilot review on iplib removal
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enumerates
1<<hostBitsaddresses and also preallocates the slice to that size. For inputs like IPv4/0(hostBits=32) or IPv6/65(hostBits=63), this will attempt to allocate/enumerate billions to quintillions of entries and will reliably OOM/hang. Consider adding a hard upper bound on the number of hosts that can be expanded (or at least reject prefixes wherecountexceeds a reasonable limit /math.MaxInt) to avoid config-triggered resource exhaustion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in c35f046. Tightened the upper bound from 2^63 to 2^16 host bits (
maxHostBits = 16), so the maximum enumerable range is now a /16 for IPv4 (65,536 addresses) or /112 for IPv6. Wider prefixes like /0 or /8 now return an error immediately instead of attempting a huge allocation. Added test cases for10.0.0.0/0and192.168.0.0/8to verify.