Skip to content

Strip SQL -- comments before executing migration statements #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Strip SQL -- comments before executing migration statements #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ff1b9
Initial plan
Copilot May 26, 2026
4411c3c
Strip SQL -- comments in executeQueryFile and add tests
Copilot May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/MigrationCore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ private function executeQueryFile(string $filename): void
$start = 0;
$end = 0;
} else {
$line = trim((string)preg_replace('/--.*/', '', $line));
if ($line === '') {
continue;
}
$start = $start > 0 ? $start : $index;
$end = $index;
$current_request .= $current_request !== '' ? PHP_EOL : '';
Expand Down
37 changes: 37 additions & 0 deletions test/MigrationCoreSecurityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,41 @@ public function testUntamperedMigrationDoesNotRaiseException(): void
$this->runSilent($core);
$this->addToAssertionCount(1);
}

// -------------------------------------------------------------------------
// Nettoyage des commentaires SQL
// -------------------------------------------------------------------------

public function testSqlLineCommentIsStripped(): void
{
$sql = "CREATE TABLE comment_test (id INTEGER PRIMARY KEY) -- cette table est un test";
$this->createSqlFile($sql);
$core = $this->makeCoreWithDb();
$this->runSilent($core);
$this->addToAssertionCount(1);
}

public function testFullyCommentedOutQueryIsIgnored(): void
{
$sql = "CREATE TABLE comment_only_test (id INTEGER PRIMARY KEY)\n---\n-- DROP TABLE comment_only_test";
$this->createSqlFile($sql);
$core = $this->makeCoreWithDb();
$this->runSilent($core);
$this->addToAssertionCount(1);
}

public function testMixedCommentAndRealSqlExecutesCorrectly(): void
{
$sql = implode("\n", [
'-- création de la table',
'CREATE TABLE mixed_comment_test (id INTEGER PRIMARY KEY)',
'---',
'-- requête mise en commentaire',
'-- DROP TABLE mixed_comment_test',
]);
$this->createSqlFile($sql);
$core = $this->makeCoreWithDb();
$this->runSilent($core);
$this->addToAssertionCount(1);
}
}