Avoid syntax warnings when IO is not loaded#24
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 55.07% 55.48% +0.41%
==========================================
Files 25 25
Lines 1380 1386 +6
==========================================
+ Hits 760 769 +9
+ Misses 620 617 -3
🚀 New features to boost your workflow:
|
fingolfin
reviewed
Sep 4, 2025
2366be4 to
4bc30e0
Compare
fingolfin
reviewed
Sep 4, 2025
4bc30e0 to
1743ada
Compare
fingolfin
reviewed
Sep 7, 2025
fingolfin
reviewed
Sep 7, 2025
fingolfin
reviewed
Sep 7, 2025
lib/serre.gi
Outdated
| fi; | ||
| if parallel <> fail then | ||
| # if the parallel option is set | ||
| if IsPackageMarkedForLoading("IO", ">= 4.7.0") then |
Member
There was a problem hiding this comment.
This line could be removed now (and then the else/fi as well of course)
Member
|
I've applied the changes I suggested and did some more cleanup. |
Member
Author
|
Nice simplification. |
fingolfin
approved these changes
Sep 7, 2025
Member
|
Thanks for working on this. For some reason I don't get notifications for this repo emailed to me. |
This was referenced Sep 7, 2025
Merged
dimpase
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack to resolve #23; perhaps @fingolfin or someone else has a nicer solution?