-
Notifications
You must be signed in to change notification settings - Fork 180
Don't transfer nice monos when conjugating #6207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I understand that comment, that the nice mono should not be used when conjugating. On the other hand, #6183 conjugates the mono. But I am fine with it either way |
ThomasBreuer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is o.k., perhaps we should add a comment in the code why we do not transfer the known NiceMonomorphism value.
|
Perhaps the formulation
can be misunderstood. The code from #6183 that stores a However, not storing the |
Agreed... but in the most literal reading, I think it is appropriate: that issue is "semigroups tests started to fail", and this is fixed by this PR.
Yes and no. I think there are at least two different issues behind #6205, and I made two PRs to address them. This PR fixes the failures reported in #6205 because the code removed here caused a regression in the quality of the nice monomorphism being computed: instead of a perm rep on 8 points we suddenly produced one on 80 points. This regression was in two ways lucky:
Yeah but it shows up in other, harder to measure ways, in that some computations will perform worse, etc. |
We tried this but then decide against it, because we determined that often you conjugate precisely so that you get a nicer description of a group. But by accident the code implementing it got merged anyway.
c51fc59 to
45a0f5e
Compare
We tried this but then decide against it, because we determined that often you conjugate precisely so that you get a nicer description of a group (see also Thomas' comment on PR #6183. But by accident the code implementing it got merged as part of PR #6183. Oops
Like PR #6206, this also fixes #6205 :-).