Skip to content

fix(params): Use correct event name pull_request (omit _target)#1595

Open
8R0WNI3 wants to merge 1 commit intogardener:masterfrom
8R0WNI3:8R0WNI3-fix-params
Open

fix(params): Use correct event name pull_request (omit _target)#1595
8R0WNI3 wants to merge 1 commit intogardener:masterfrom
8R0WNI3:8R0WNI3-fix-params

Conversation

@8R0WNI3
Copy link
Copy Markdown
Member

@8R0WNI3 8R0WNI3 commented May 8, 2026

GitHub does not emit an event called pull_request_target but only a pull_request one. This one should be used instead to retrieve the respective author association (consistently like how it is done in the trusted-checkout action). Refs:

Release note:

Correctly determine author association in params action determine "can-push" status later

GitHub does not emit an event called `pull_request_target` but only a
`pull_request` one. This one should be used instead to retrieve the
respective author association (consistently like how it is done in the
trusted-checkout action). Refs:
- https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request
- https://github.com/gardener/cc-utils/blob/7dd669e3ca119ba3a0de8ce49815928dd25b5a3e/.github/actions/trusted-checkout/action.yaml#L255

Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
@8R0WNI3 8R0WNI3 requested review from TuanAnh17N and ccwienk as code owners May 8, 2026 10:00
@gardener-prow gardener-prow Bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 8, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 8r0wni3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant