fix(bootstrap): cover v0.34.1 oauth_clients.{source_id, federated_read} columns

[ChenyqThu]

Why

applyForwardReferenceBootstrap in both PostgresEngine and PGLiteEngine covers 9 forward-reference targets that schema-embedded.ts makes (pages.source_id, pages.deleted_at, links., content_chunks., mcp_request_log.*, subagent_messages.provider_id, ingest_log.source_id, …) — but missed v0.34.1's oauth_clients.{source_id, federated_read} additions.

Result: brains upgrading from a pre-v0.34 schema (which has oauth_clients but neither column) crash at schema-embedded.ts during SCHEMA_SQL replay with:

column "source_id" does not exist

…on the partial-index CREATE INDEX idx_oauth_clients_source_id ON oauth_clients(source_id) WHERE source_id IS NOT NULL and on the parallel idx_oauth_clients_federated_read GIN-index DDL. Migrations v60-v65 backfill both columns + RLS policies later, but they can't run until SCHEMA_SQL replay succeeds, so the bootstrap must add enough state up front.

Patch shape

Same pattern as #627 (superseded by upstream fixwave #682+#741 for mcp_request_log v0.26.3 columns):

1. Probe rows in the existing information_schema EXISTS round-trip — oauth_clients_exists, oauth_source_id_exists, oauth_federated_read_exists.
2. needsOauthClientsBootstrap when the table exists but either column is missing.
3. Early-return guard extended so fresh installs and modern brains still no-op.
4. ALTER TABLE block at the end of the function alongside the other missing-column bootstraps. source_id picks up its FK to sources(id) and federated_read its NOT NULL DEFAULT '{}'.

Mirrored across src/core/postgres-engine.ts and src/core/pglite-engine.ts. Doc comments at the top of each function updated to list the new coverage.

Test follow-through

test/schema-bootstrap-coverage.test.ts gains two entries in REQUIRED_BOOTSTRAP_COVERAGE (oauth_clients.source_id, oauth_clients.federated_read). The existing contract test strips both columns, runs the bootstrap, then asserts they exist after SCHEMA_SQL replay — same loop as every other v33+ column the test already covers.

E2E test (test/e2e/postgres-bootstrap.test.ts) was not extended in this PR — its single "pre-v0.18" mutation scenario is structurally identical for any forward-reference target, and the contract test already validates the per-column bootstrap. Happy to add an oauth-specific E2E case if maintainers prefer.

Validation

• bun run typecheck clean
• bun test test/schema-bootstrap-coverage.test.ts test/bootstrap.test.ts:
  • 11 pass / 0 fail (was 11 pass with 48 expect() calls; now 50 — the +2 new probes)

Field repro

Hit during the Jarvis KOS v2 fork's v0.31.2 → v0.34.4 sync (commit 1b6acd77):

• bun install postinstall ran gbrain apply-migrations (requires schema_version ≥ 51 for the v0.32.2 facts orchestrator).
• Schema was at v45. Running gbrain init --migrate-only to bump v45 → v66 failed at the idx_oauth_clients_source_id DDL.
• Worked around with one manual ALTER TABLE oauth_clients ADD COLUMN IF NOT EXISTS source_id … / federated_read …; migrations v60-v65 then ran clean in under a minute.
• Same shape as the mcp_request_log trap that produced fix(bootstrap): cover v0.26.3 mcp_request_log columns #627 in our v0.26.7 sync.

🤖 Generated with Claude Code

[ChenyqThu]

Superseded by upstream v0.35.5.0 (4446e9f9, PR #1111).

The v0.35.5.0 fix(bootstrap): extend probes for files/oauth_clients/sources.archived* + add MIGRATIONS introspection guard commit is a strict superset of this PR:

• Covers oauth_clients.{source_id, federated_read} (this PR's scope)
• Also covers files.{source_id, page_id} (v0.18 forward refs, Bootstrap gap: applyForwardReferenceBootstrap misses files.source_id + files.page_id (v0.18 forward-refs) #974)
• Also covers sources.{archived, archived_at, archive_expires_at} (v0.26.5 v34 promotion)
• Adds DDL connection threading (Codex P1 catch — bootstrap probes now run inside the advisory lock)
• Adds MIGRATIONS-source introspection contract test that catches the entire column-only forward-ref bug class at PR time

Same pattern as #627 (closed when v0.31.1.1 fixwave superseded with broader v0.20 + v39-v41 column coverage).

Production impact for jarvis-knowledge-os-v2 fork: already manually ALTER-ed on the prod DB during v0.34.4 sync (per docs/JARVIS-ARCHITECTURE.md §6.24); v0.35.6.0 sync landed today (2026-05-17) and bun install postinstall confirmed All migrations up to date with no manual intervention needed.