fix(doctor): run PGLite probes through active engine#1183
Open
duncanclaw wants to merge 1 commit into
Open
Conversation
51397b4 to
77da61f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two false-positive
gbrain doctorwarnings for PGLite-backed brains:pgvectorprobe through the activeBrainEnginejsonb_integrityprobe through the activeBrainEngineRoot Cause
The doctor had two remaining direct calls to the module-level Postgres singleton:
db.getConnection()forpg_extensiondb.getConnection().unsafe(...)for JSONB integrity scanningThat works for Postgres-backed brains, but PGLite uses
PGLiteEngineand does not initialize the Postgres singleton. The result was a false warning on healthy embedded brains:The underlying PGLite engine can answer both SQL probes correctly; the doctor was just bypassing it.
Real Behavior Proof
pgvectorandjsonb_integritysolely because no external Postgres singleton is connected.bun test test/doctor.test.ts bun run typecheck bash scripts/check-no-legacy-getconnection.sh bun run check:jsonb gbrain doctorpgvectorandjsonb_integrityboth report OK.Regression Test Plan
test/doctor.test.tspgvectorCheck(PGLiteEngine)andjsonbIntegrityCheck(PGLiteEngine)both return OK after schema initialization.Verification
bun test test/doctor.test.tsbun run typecheckbash scripts/check-no-legacy-getconnection.shbun run check:jsonbUser-visible Behavior
PGLite users should see fewer false
gbrain doctorwarnings. No CLI flags, config keys, migrations, or data-shape changes.