Add uninstall link to install section + NO FINDINGS sanity check#856
Open
urbantech wants to merge 1 commit intogarrytan:mainfrom
Open
Add uninstall link to install section + NO FINDINGS sanity check#856urbantech wants to merge 1 commit intogarrytan:mainfrom
urbantech wants to merge 1 commit intogarrytan:mainfrom
Conversation
README.md (garrytan#801): Add one-line uninstall reference right after the install command so users who paste-install can find it without scrolling. Links to the existing Uninstall section for manual steps. review/SKILL.md, ship/SKILL.md (garrytan#839): Add sanity check when ALL specialists return NO FINDINGS on a non-trivial diff (>50 lines). Warns the user about possible configuration issues (wrong branch, empty diff, skills not reading files) before proceeding with clean result. Fixes garrytan#801, fixes garrytan#839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#801 — Add uninstall steps to README
The install section now includes a one-line uninstall reference right after the install command:
The existing Uninstall section (with full manual steps) is already comprehensive — this just makes it discoverable from the install section where new users land.
#839 — Post-review sanity check when all specialists return NO FINDINGS
Added to both
review/SKILL.mdandship/SKILL.md:When ALL specialist subagents return "NO FINDINGS", the review now:
git diff --stat)This catches silent misconfiguration without blocking legitimately clean reviews.
Test Plan
Fixes #801, fixes #839