feat: add sqry structural code analysis as add-in#862
Open
mr-k-man wants to merge 8 commits intogarrytan:mainfrom
Open
feat: add sqry structural code analysis as add-in#862mr-k-man wants to merge 8 commits intogarrytan:mainfrom
mr-k-man wants to merge 8 commits intogarrytan:mainfrom
Conversation
Routing contract (tools.json), detection fragment, install/uninstall scripts, and README for the sqry structural code analysis add-in. Follows the established contrib/add-tool pattern from llm-gateway. Parameter guidance is delegated to sqry's live MCP resources (sqry://docs/capability-map, sqry://docs/tool-guide) per the v8 resource delegation architecture.
TypeScript resolver reads contrib/add-tool/sqry/tools.json and generates conditional markdown per skill. Delegates parameter guidance to sqry's live MCP resources instead of hardcoding limits.
Inlines detection.sh bash fragment into preamble. Outputs SQRY, SQRY_VERSION, SQRY_INDEXED, and SQRY_STALE variables. Uses sqry's own index --status --json API (<1ms) for staleness detection.
Place after {{LEARNINGS_SEARCH}} in investigate, cso, review, retro,
plan-eng-review, and ship templates.
Generated from templates with new {{SQRY_CONTEXT}} placeholder.
Golden ship baselines updated for all three hosts.
Mirrors the llm-gateway-resolver test structure. Validates schema, tool names, MCP resource delegation, manifest health check, preamble detection, and generated SKILL.md content.
Design spec approved by Gemini 3 Pro + OpenAI Codex (4 review rounds). Includes initial implementation DAG and v8 alignment restructure DAG.
…riptions Apply techniques from TOKEN_OPTIMIZATION_GUIDE: remove filler phrases, terse descriptions, arrow notation for conditionals, consolidate repeated prose. Resolver output reduced from 33 to 22 lines per skill. tools.json when-clauses shortened (remove articles, leading verbs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contrib/add-tool/pattern/investigate,/cso,/review,/retro,/plan-eng-review,/shipArchitecture: WHEN vs HOW
tools.jsondefines which sqry tools to use at which skill phase — that's gstack's value-add. Parameter guidance (max_depth, max_results, scoping, cost tiering) is delegated to sqry's live MCP resources (sqry://docs/capability-map,sqry://docs/tool-guide), which always match the user's installed version and update automatically. No hardcoded limits that can drift.Review history
Eval results
Two full runs. Zero failures from this PR — all failures are environmental (missing browse binary, codex API unreachable).
Test plan
bun test— 155 pass, 0 fail (sqry resolver tests)bun run test:evals— all non-environmental tests pass across 10 suites{{SQRY_CONTEXT}}placeholders--host all)