Skip to content

Add integer check for alphabet size #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heapframe wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −0
Open

Add integer check for alphabet size #2458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e720557
Add integer check for alphabet size
heapframe May 27, 2026
eedc3fc
Merge branch 'master' into patch-1
GCHQDeveloper581 May 28, 2026
7717640
Add validation for key length in De Bruijn sequence
heapframe May 28, 2026
e63a285
Merge branch 'master' into patch-1
heapframe May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/core/operations/GenerateDeBruijnSequence.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,14 @@ class GenerateDeBruijnSequence extends Operation {
throw new OperationError("Invalid alphabet size, required to be between 2 and 9 (inclusive).");
}

if (!Number.isInteger(k)) {
throw new OperationError("Invalid alphabet size, required to be integer.");
}

Comment on lines +53 to +56
Copy link
Copy Markdown
Contributor

@GCHQDeveloper581 GCHQDeveloper581 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a similar test / error for n not being an integer

if (!Number.isInteger(n)) {
throw new OperationError("Invalid key length, required to be integer.");
}

if (n < 2) {
throw new OperationError("Invalid key length, required to be at least 2.");
}
Expand Down