feat(backend): retire mock wallet auth and unify challenge verification#319
Merged
Merged
Conversation
|
@Ezeh20 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Kaylahray
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Retires the legacy mock wallet authentication path and makes the SEP-10 challenge/verify flow the canonical production auth model for both login and registration.
Fixes #306
This change removes legacy mock signature verification from production auth flows, centralizes secure wallet verification in a shared backend helper, preserves replay protection through used challenge tracking, and updates the wallet auth UI to sign server-issued Stellar challenges instead of plain messages.
Checklist
npx prisma generateafter schema changesnpx prisma migrate devornpx prisma migrate deployas appropriateNotes:
corepack pnpm exec vitest run tests/api/auth-credentials.test.ts tests/lib/wallet-auth.test.tsnpx prisma generatePost-Merge Steps for Maintainers
If this PR includes changes to the Prisma schema:
Run the following command to apply the migration to your database: