Added support for snapshot, saving all images, and path to where images are saved#10
Open
willlewin wants to merge 1 commit into
Open
Added support for snapshot, saving all images, and path to where images are saved#10willlewin wants to merge 1 commit into
willlewin wants to merge 1 commit into
Conversation
Member
|
Hi! Thank you very much for the pull request and for paying your effort on it. I know there are so many people who had wanted to have the feature in the Harvester GUI so they would appreciate that once it's merged. However, now I'm on a business trip to an oversea country so would you mind if I review the proposed changes once I get back to my home? I hope you understand the situation. Thank you again! |
Author
|
Hi Kazunari,
I don’t mind at all, thanks for your quick response. Enjoy your trip!
Cheers,
Will
From: Kazunari Kudo <notifications@github.com>
Sent: Thursday, 17 October 2019 6:58 AM
To: genicam/harvesters_gui <harvesters_gui@noreply.github.com>
Cc: willlewin <william.lewin@live.com>; Author <author@noreply.github.com>
Subject: Re: [genicam/harvesters_gui] Added support for snapshot, saving all images, and path to where images are saved (#10)
Hi! Thank you very much for the pull request and for paying your effort on it. I know there are so many people who had wanted to have the feature in the Harvester GUI so they would appreciate that once it's merged. However, now I'm on a business trip to an oversea country so would you mind if I review the proposed changes once I get back to my home? I hope you understand the situation. Thank you again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#10?email_source=notifications&email_token=AKDHBK222VBVOAXJWE7NLP3QO5W4BA5CNFSM4JBFI7YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNXXBQ#issuecomment-542866310>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKDHBK7QWPNWZWYIVDH2CD3QO5W4BANCNFSM4JBFI7YA>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kazunari, I needed a software solution to record video from an USB3 vision compliant IDS camera. I added some features here and in your core repo to allow for all acquired images to be saved to disk or snapshots to be taken when the acquisition is paused (stopped drawing).
It's based off the core 0.2.11 release tag because it looks like the later changes are incompatible with the GUI version.