refactor(permissions): centralize permission checks#1
Merged
Merged
Conversation
- Replace hardcoded role permissions in ProtectedRoute with reusable hasPermission utility - Update nav items and routes to use standardized PERMISSIONS enum values - Fix Accounts page permission check to use correct ACCOUNTS_MANAGE permission - Add type safety and explanatory comments to auth and route files
Add @vitest/coverage-v8 to support test coverage reporting. Add a new typecheck npm script alias for tsc -b type checks. Update vitest to version 4.1.6, and clean up package registry references in the lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #(issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Test Configuration:
Checklist:
Screenshots (if appropriate):
Additional context:
Add any other context about the pull request here.