feat: drop support for symfony < 6 #389
Conversation
WalkthroughThe pull request updates composer.json to drop Symfony 5.4 support across production and development dependencies. Minimum versions are raised to Symfony 6.4 for all symfony packages, and nyholm/symfony-bundle-test is updated to ^3.1. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composer.json
🔇 Additional comments (3)
composer.json (3)
20-22: Consistent Symfony version constraints updated across production dependencies.The removal of Symfony 5.4 support is consistent across all production dependencies, aligning with the PR objective. Symfony 6.4 is an LTS version, making it a solid minimum requirement.
58-58: Clarify the rationale for ^3.1 constraint.Version 3.0.0 supports Symfony ^5.4 || ^6.0 || ^7.0, which includes Symfony 6.4. Version 3.1.0 extends support to include ^8.0. Using
^3.0would suffice for Symfony 6.4 support. If^3.1is intentional, confirm whether it's for Symfony 8.0 compatibility or another reason; otherwise, consider relaxing the constraint to^3.0.
62-68: Symfony dev dependencies consistently updated to minimum Symfony 6.4.All Symfony development dependencies have been updated to require version 6.4 or newer, maintaining alignment with the production dependencies. The required versions of symfony/cache, symfony/config, symfony/http-client, symfony/phpunit-bridge, symfony/validator, symfony/var-exporter, and symfony/yaml all require ^6.4 || ^7.0 || ^8.0 in the latest builds, confirming this change pattern is appropriate for the Symfony dependency updates.
| "symfony/console": "^6.4 || ^7.0 || ^8.0", | ||
| "symfony/framework-bundle": "^6.4 || ^7.0 || ^8.0", | ||
| "symfony/options-resolver": "^6.4 || ^7.0 || ^8.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for CHANGELOG and UPGRADE documentation files
echo "=== Checking for CHANGELOG files ==="
fd -t f -i 'changelog' -E vendor -E node_modules 2>/dev/null || echo "No CHANGELOG found"
echo -e "\n=== Checking for UPGRADE files ==="
fd -t f -i 'upgrade' -E vendor -E node_modules 2>/dev/null || echo "No UPGRADE found"
echo -e "\n=== Checking for README files ==="
fd -t f 'README*' -E vendor -E node_modules 2>/dev/null | head -10
echo -e "\n=== Examining composer.json structure ==="
head -100 composer.jsonRepository: geocoder-php/BazingaGeocoderBundle
Length of output: 3397
🏁 Script executed:
#!/bin/bash
# Check CHANGELOG.md content - look for Symfony 5.4 removal documentation
echo "=== CHANGELOG.md content (first 150 lines) ==="
head -150 CHANGELOG.md
echo -e "\n=== Checking for Unreleased section or version 6.0 ==="
grep -A 20 -i "unreleased\|^## \[6\|^## 6" CHANGELOG.md | head -40
echo -e "\n=== Checking README.md for version requirements ==="
grep -i "symfony\|version\|requirement" README.md | head -20Repository: geocoder-php/BazingaGeocoderBundle
Length of output: 2816
🏁 Script executed:
#!/bin/bash
# Check for more comprehensive CHANGELOG content, especially looking for 6.0 or unreleased entries
echo "=== Full CHANGELOG.md (checking for version 6.0 or Unreleased entries) ==="
grep -i "^## \|^# " CHANGELOG.md
echo -e "\n=== Checking line count and structure of CHANGELOG.md ==="
wc -l CHANGELOG.md
echo -e "\n=== Check for any mentions of Symfony 5 removal ==="
grep -i "symfony 5\|remove.*symfony\|drop.*symfony" CHANGELOG.md
echo -e "\n=== README.md - full check for requirements/version info ==="
cat README.md | head -80Repository: geocoder-php/BazingaGeocoderBundle
Length of output: 3057
Document the breaking change in CHANGELOG.md before merging.
This PR removes Symfony 5.4 support, which is a breaking change that impacts users currently on older versions. The version 6.0 entry must be added to CHANGELOG.md documenting the minimum Symfony version requirement change from ^5.4 to ^6.4. Consider creating an UPGRADE.md guide to help users migrate from version 5.x to 6.0.
🤖 Prompt for AI Agents
In composer.json around lines 20 to 22, the dependency change removes Symfony
5.4 support which is a breaking change; update CHANGELOG.md by adding a "v6.0"
(or "6.0.0") entry that explicitly documents the minimum Symfony requirement
change from ^5.4 to ^6.4 and describes the impact for users, and create an
UPGRADE.md (or add a section) with concise migration steps and notable
incompatibilities for upgrading from 5.x to 6.0; commit both files alongside
this PR before merging.
3 participants
i just noticed that it was already removed from the ci.
nyholm/symfony-bundle-testcould be bumped to 3.1Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.