Support SPA URL changes via chrome.webNavigation#34
Open
kokoichi206 wants to merge 2 commits intogeovanneb:masterfrom
Open
Support SPA URL changes via chrome.webNavigation#34kokoichi206 wants to merge 2 commits intogeovanneb:masterfrom
kokoichi206 wants to merge 2 commits intogeovanneb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for sharing this awesome Chrome extension!
Single-page apps often change the URL via
history.pushState/replaceStateonly (for example the Supabase dashboard), so relying solely onhashchangeleft the environment ribbon stuck in the previous state.The background script now listens to
chrome.webNavigation.onHistoryStateUpdated, sends aurlChangedmessage, and the content script toggles the ribbon accordingly, so_addEnvironmentLabelreruns on those virtual SPA navigations as well.Adding another permission is always sensitive, but here
webNavigationis strictly used to detect History API transitions so the ribbon stays accurate.Please let me know if this raises any policy concerns.
Thanks again!